chore: Give fork PRs a clear create-vsix failure message - #1770
Merged
Conversation
Applying the `create-vsix` label to a PR opened from a fork starts the job, but GitHub withholds repository secrets from fork-triggered runs, so it failed with a cryptic "Input required and not supplied: app_id". Detect the fork up front and fail with an actionable message pointing contributors at a manual workflow_dispatch run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Applying the
create-vsixlabel to a PR opened from a fork starts this job, but GitHub withholds repository secrets from fork-triggered runs. The run then died with a cryptic:Nothing in that message says "this is a fork" or "here's what to do instead", so it reads like a broken workflow rather than an expected limitation.
Change
Detect the fork up front and fail immediately with an actionable message:
Notes:
::error::so the text surfaces as an annotation in the Actions UI, not just in the log.workflow_dispatchthere's nopull_requestpayload, so theifis falsy and the step skips — that's the path a maintainer uses to build a fork PR's .vsix.Matches rokucommunity/vscode-brightscript-language#864, where the message and annotation rendering were verified on a live run.
🤖 Generated with Claude Code